Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6] 공고 삭제 기능 구현 #13

Merged
merged 8 commits into from
Nov 10, 2024

Conversation

Younggun-Kim
Copy link
Collaborator

변경사항

  • 공고 삭제 기능 구현
  • 공용 삭제 응답 모델인 DeleteResponseDto 추가

Screenshot

_._.webm

�Issues

close #6

1. DeleteResponseDto 추가
2. 공고 삭제 API 추가
1. deleteJobPosting 메소드 추가
1. deleteJobPosting 메소드 추가
1. 삭제 버튼 클릭 시 Bloc 삭제 이벤트 연결
2. 실패 메시지 노출 후 초기화 이벤트 추가
1. 서버 응답에 맞게 코드 수정
@Younggun-Kim Younggun-Kim self-assigned this Oct 23, 2024
Copy link

@abdul0986 abdul0986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 확인 부탁드립니다.

required String jobPostingId,
}) async {
final result =
await repository.deleteJobPosting(jobPostingId: jobPostingId);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await repository.deleteJobPosting(jobPostingId: jobPostingId);
await repository.delete(id: jobPostingId);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11 PR 수정하면서 같이 반영해 푸시했습니다!
jobPostingRepo.delete()로 사용할 수 있게 변경했습니다!

Copy link

@abdul0986 abdul0986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Younggun-Kim Younggun-Kim merged commit 51eb3a0 into feature/5-job-posting-close Nov 10, 2024
1 check passed
@Younggun-Kim Younggun-Kim deleted the 6-job-posting-delete branch November 10, 2024 15:51
@Younggun-Kim Younggun-Kim restored the 6-job-posting-delete branch November 10, 2024 15:51
@Younggun-Kim Younggun-Kim deleted the 6-job-posting-delete branch November 20, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants